Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to not split recorded mix files #8130

Open
mixxxbot opened this issue Aug 22, 2022 · 6 comments
Open

option to not split recorded mix files #8130

mixxxbot opened this issue Aug 22, 2022 · 6 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: Be-ing
Date: 2015-06-28T15:27:56Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1469529


There are options to split recorded mixes at various file sizes. It would be nice to have a check box to disable splitting the file.

@mixxxbot
Copy link
Collaborator Author

Commented by: JosepMaJAZ
Date: 2016-10-31T19:34:09Z


I am currently working on the recording engine, and I believe that this should not be an option.

Concretely, I believe that such use cases should use the biggest size, which is 4GB. (Maybe it could be labeled as indicating max allowed size)

Also, it is important to note that due to the way that this is implemented, it only splits the "WAVE" and "AIFF" recorders, because the others are not currently reporting the written size.

Reasons why the 4GB limit should be kept:
the WAV and AIFF container formats that we are using are 32bit. This means that they cannot indicate a size bigger than 4GB.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2016-10-31T20:41:18Z


Ah, I was not aware that WAV and AIFF have a 4 GB maximum. There are alternative PCM container formats that do not have this limit, but they are esoteric and I don't think much software or hardware works with them. However, I don't think FLAC has such a small file size limit (I'm not sure if it has any file size limit). So it would make sense to remove the 4 GB file size limit when implementing FLAC recording:
https://bugs.launchpad.net/mixxx/+bug/683633

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-05-19T16:11:15Z


Now we have the 4 GB Maximum.
The rest will not be fixed, to not risk loosing data.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2020-05-19T16:42:04Z


We have FLAC recording now, so this is still valid. There is no reason a FLAC file needs to be split at an arbitrary file size.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-02-10T17:42:33Z


FWIW, in practice I have only ever been affected by this with FLAC once during the longest set I have played (yet) which was >7 hours.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2021-02-12T03:14:11Z


We should add some verbiage that indicates that not all files are split.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant