Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzy BPM search #8191

Closed
mixxxbot opened this issue Aug 22, 2022 · 12 comments · Fixed by #12072
Closed

fuzzy BPM search #8191

mixxxbot opened this issue Aug 22, 2022 · 12 comments · Fixed by #12072

Comments

@mixxxbot
Copy link
Collaborator

Reported by: Be-ing
Date: 2015-08-04T16:23:09Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1481411


It would be convenient to have a fuzzy BPM search operation rather than manually typing in a BPM range. For example "~bpm:115" could search for tracks with a BPM within 5 (or whatever number is decided upon) BPM of 115.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-08-04T19:36:50Z


We already support
bpm:140
bpm: >140
bpm: >=140
bpm: 140-150

~bpm:115 looks wrong in this relation.

I think we support

~key:2A

but not the obvious key:~2A :-(

I would not be able to guess it.

I think we should support both.

@rryan: Is there something I have forgot?

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2015-08-04T19:48:47Z


I disagree. I'd rather see that the current track's BPM is 145 and type "~bpm:145" than think about how far from the current BPM I want to search then add and subtract that number from the current track's BPM then type out that range.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-08-04T19:59:07Z


Ah sorry, my comment was misleading.
The proposed feature is useful.

I prefer only bpm:~145 over ~bpm:145
That's all.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2015-08-04T22:37:28Z


Oh, I see. Yeah, bpm:~145 makes more sense.

@mixxxbot
Copy link
Collaborator Author

Commented by: dg3nec
Date: 2015-09-18T08:03:38Z


Little hint from my side for the range that will be searched around the ~BPM.

Use the "pitch range" (or half) for the search range. BPM outside of this range are not usefull.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-01-12T15:26:27Z


Use the "pitch range" (or half) for the search range.
+1 for that

another aspect if this request:
when searching bpm:~NN can we also show tracks with BPM that's halve/double of NN? or is that tooo far from the filtering suggested here?

my use case is mixing of footwork or dnb/jungle tracks with hiphop and other similiar slow beats, and it's tedious to basically alter the search string back & forth between '80-86' and '160-175'
Also I have halftime-dnb tracks (~86) where I left the detected BPM (and not double it to 170-176), but of course I'd like to mix them with tracks with regular dnb bpm.

@mixxxbot
Copy link
Collaborator Author

Commented by: kazakore
Date: 2019-05-25T13:15:19Z


Was just searching for such an open request to make exactly the same comment as you ronso0. I really need to be able to limit my views to tracks within a range of current BPM including tracks within the range of half and double that BPM! Repeated scrolling up and down up and down is extremely tiresome!

I also though fuzzy searching for BPM currently worked but testing it could make it do so....

I think bpm:~175 (for example) looks better but it should be standardised and Key currently works with ~key:1d and not wih key:~1d....

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@veeroohre
Copy link

Would love to see this feature. You think it will be implemented soon? (or is it already and I didn't see the feature?)

@daschuer
Copy link
Member

daschuer commented Jun 6, 2023

I don't think it is implemented. We have a "search related" feature in 2.4-beta:
#3181

But introducing the fuzzy operator is still missing.

It can be straight forward implemented by translating it in a range near this file:
https://github.com/mixxxdj/mixxx/blob/018cb521b27bc1e7b1abf37c039a8de179fd97da/src/library/searchquery.cpp

You will wait forever if we find no contributor for this feature, unfortunately. Or do you have interest to to implement it?

@ronso0 ronso0 added the search label Jun 6, 2023
@veeroohre
Copy link

I'm afraid I'm not able to implement it. I have zero C++ knowledge. Only a little bit of python experience. :-(

@ronso0
Copy link
Member

ronso0 commented Oct 6, 2023

another aspect if this request:
when searching bpm:~NN can we also show tracks with BPM that's halve/double of NN? or is that tooo far from the filtering suggested here?

I finally took a stab at implementing this #12070

As @daschuer mentioned, the fuzzy search has been added (in a way) via the 'Search related Tracks' menu. That has an action to search for +-6 BPM. This is happening transparently, i.e. the query is copied to the search box and can be extended by other filters.

@ronso0
Copy link
Member

ronso0 commented Oct 6, 2023

Now that I fumbled around with the filters I think ~bpm: should be rather easy to implement. Let's see...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants