Controller script loader always uses local copy

[mixxxbot]

Reported by: Pegasus-RPG
Date: 2015-11-26T02:46:21Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1520047
Tags: controllers, midi, scripting

---

As I update controller scrips, I'm editing the file in /res/controllers and running Mixxx with --resourcePath res/

I repeatedly tell it to reload the preset (choosing the second of the same name in the list because I know the first is my local copy) and the XML is updated correctly, but if a copy of the JS file is in my ~/.mixxx directory, it uses that regardless. I have to manually delete that copy in order for it to try using the copy in res/.

This is serious because it will cause all kinds of problems when users try to load updated presets after upgrading.

[mixxxbot]

Commented by: ywwg
Date: 2015-11-26T22:58:20Z

---

if we already do the right thing with respect to XML, then we should definitely fix this for js.

[mixxxbot]

Commented by: ywwg
Date: 2015-11-26T23:11:46Z

---

which preset? There is code that is supposed to do the right thing in dlgprefcontroller.cpp:380.

[mixxxbot]

Commented by: ywwg
Date: 2015-11-26T23:14:54Z

---

reproduced, working on this now

[mixxxbot]

Commented by: ywwg
Date: 2015-11-26T23:25:53Z

---

So the problem is that when the user picks an item from the preset menu, the listitem contains the full path of the preset to import -- either the user's preset, or the system preset. But the scripts are loaded dynamically, and it looks first in the user's dir, and if it finds the script, it's done.

To fix this, we have to know which preset they are loading and load the script from the same path.

Should we put up a warning box when presets are loaded, indicating that users might lose customization?

[mixxxbot]

Commented by: ywwg
Date: 2015-11-26T23:30:28Z

---

oh, hah, we increment the filename, no need to warn the user

[mixxxbot]

Commented by: ywwg
Date: 2015-11-26T23:37:35Z

---

e47ff90

[mixxxbot]

Commented by: Pegasus-RPG
Date: 2015-11-27T05:25:26Z

---

Sweet, thanks for the quick fix!

[mixxxbot]

Issue closed with status Fix Released.