Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total number of tracks not read from file tags #8398

Closed
mixxxbot opened this issue Aug 22, 2022 · 5 comments
Closed

Total number of tracks not read from file tags #8398

mixxxbot opened this issue Aug 22, 2022 · 5 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: uklotzde
Date: 2015-12-30T20:07:39Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1530203


Mixxx only reads the track number, but ignores the total number of tracks.

TagLib does not provide a common API for total tracks. The total number of tracks is stored differently depending on the tag type:
- ID3v2/APE: Optionally appended to the track number string: "<trackNumber>" or "<trackNumber>/<totalTracks>"
- MP4: Track number and total tracks are stored together in a single atom as a pair of integers
- Vorbis Comments: Stored in a separate field "TRACKTOTAL" (sometimes "TOTALTRACKS")

The missing handling of total tracks becomes even worse when enabling tag writing. In this case the total number of tracks tag is lost (ID3v2/APE) or reset to 0 (MP4) internally by TagLib.

Solution:
The track number in Mixxx is already represented as a string. This string should be formatted according to the ID3v2/APE convention with an optional number of total tracks appended, separated by a single slash "/" from the track number. When updating tags in files this string will either be written directly into the corresponding frame/item for ID3v2/APE or split into separate numbers for MP4 and Vorbis Comments. This change is backwards compatible and does not require an update of the database schema.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-12-30T20:15:14Z


The proposed solution is already implemented as part of the "Write audio tags" PR:

#728

I will open a separate PR for this issue after the "PlayCounter" PR has been merged. The "PlayCounter" PR is actually unrelated, but rebasing the "Write audio tags" PR on multiple base branches to keep it aligned with master would be too much effort.

@mixxxbot mixxxbot added the bug label Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-12-30T20:21:51Z


This is a fix I would like to see for 2.1, even if tag writing is still disabled. The longer we ignore the total number of tracks, the more information is missing in the Mixxx library. This becomes obvious when writing metadata from the Mixxx library back into file tags.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2015-12-31T15:16:31Z


#834

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2016-01-01T10:25:25Z


I forgot to update the table views:
#835

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant