Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missleading error meassage when settingsPath can not be accessed #8721

Open
mixxxbot opened this issue Aug 23, 2022 · 6 comments
Open

Missleading error meassage when settingsPath can not be accessed #8721

mixxxbot opened this issue Aug 23, 2022 · 6 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2016-12-15T09:19:54Z
Status: Triaged
Importance: Medium
Launchpad Issue: lp1650190
Tags: easy


When there are no write permissions in the setting path given by "mixxx --settingsPath", Mixxx is complaining that it can not establish a database connection.
This is missleading. Instead it should complain about the settingsPath permissions.

@mixxxbot
Copy link
Collaborator Author

Commented by: nimitbhardwaj
Date: 2016-12-21T07:25:53Z


I have found the cause of the bug, now I am solving it, its cause is in src/library/trackcollection.cpp , this happens in the constructor, which calls the open function, and results in unfaithful error message, I am going to fix it

@mixxxbot
Copy link
Collaborator Author

Commented by: sblaisot
Date: 2016-12-21T16:27:17Z


I don't think it should complain about settingspath not being writable.
It should complain about not being able to create the database file (with a user-friendly "unable to write database file to settingspath/database.sql" instead of "unable to establish a connection to database".

Trying to write to the settings path once, then relying on the result of this test to assume later it will stay writable during the whole mixxx session is imho a misconception.

@mixxxbot
Copy link
Collaborator Author

Commented by: sblaisot
Date: 2016-12-21T16:31:49Z


don't forget that settingspath is usually in $HOME and historically UNIX $HOME can be an NFS share whose ability to write in depends on network availability. Not a common setup for home desktops, but thinking of it this way leads you to appropriate way to handle this.

@mixxxbot
Copy link
Collaborator Author

Commented by: nimitbhardwaj
Date: 2016-12-23T19:11:16Z


Fix at #1086

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2018-09-20T18:16:00Z


Due to lack of progress, marking Triaged and clearing assignee. Feel
free to revert if it is in fact still in progress :).

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-05-21T11:52:33Z


the error message is still an issue, see lp:1973401

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant