-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview Deck and related widgets are shown when no Headphones output is configured #8935
Comments
Commented by: Be-ing The Preview Deck is only sent to the Headphones output, so it cannot be used with an external mixer unless your sound card and mixer both have a spare stereo pair of channels, in which case it would probably make more sense to send another regular deck instead. I think the issue here is that the UI has no indication that the preview deck is not functional when there is no Headphones output configured. Mixxx could either hide all Preview Deck widgets from the GUI or pop up a dialog explaining that the feature only works with the Headphones output configured when the preview button is pressed in the library. I think it would be better to hide the features. |
Commented by: h-pa5l-v Be: Thanks for your clarification. Perhaps, the Preview Deck could have a HEADPHONE Toggle, like the Sampler Decks. If the Preview Deck is only ever intended to be sent to headphones, I understand and this bug can be closed as intentional / won't fix. I suppose the fact that headphone output CANT be sent to an external mixer, without an additional soundcard output, would be out-of-scope for this bug report. If I'm dreaming of out-of-scope features, though, it would be neat if Mixxx could BUS / MUX multiple outputs to any single channel. |
Commented by: daschuer I am not sure what you are requesting. Which version of Mixxx you are using? Which external Mixer are you using? If your External Mixer has three inputs CH1 CH2 and Aux, it will work quite good with Mixxx. You can now always enable Aux PFL on your Mixer and use all Mixxx GUI PFL knobs and Library preview as usual. In addition you van also user the mixers PFL knobs to preview the decks. If you does not have a Aux input on your Mixer, you may use just a second pair of headphones plugged into your PC to library preview. Does it help your? What else can we do to improve your situation? |
Commented by: Be-ing I am not aware of any DJ mixers that have an auxiliary input which can be sent to headphones but not the main output. That would just be another normal deck input. The Preview deck is a convenience feature for some users who prefer to use it with internal mixing. It is not at all necessary and the use case is already supported by previewing decks normally (personally I never use it). IMO the only problem here is that the GUI for the Preview Deck is shown when the user's hardware configuration does not support it without any explanation of why the feature doesn't work. |
Commented by: h-pa5l-v Daniel: Thanks for the suggestion. You've been more than kind in indulging my questions. I don't want to waste any more of your time with this. I was just curious and I didn't understand the intended functionality of the Preview Deck. I understand now that the Preview Deck is intended for those without an external mixer. You can close this issue. Be: Thanks for answering. I agree with you that Mixxx's UI is a bit unclear on the intended functionality of the Preview Deck. I look forward to future improvements. Thanks again. |
Commented by: Be-ing I have changed the bug title to reflect the issue better. It is indeed a user experience issue, but it is a minor one. |
Commented by: ronso0 What about adding a hint like the one that pops up when trying to enable 'passthrough' although there's no vinyl/line input set up? " |
Commented by: daschuer Good idea. |
Commented by: Be-ing I disagree. I find that dialog annoying. I think it would be better to hide parts of the GUI that are not functional with the user's configuration. |
Commented by: daschuer This is a question of consistency. Currently it is implemented for vinyl control and microphone, that we can enable the widgets and the user is informed that it cannot be used via a pop up. It is somehow consistent to do it in the same way for headphones. The other way round might be confusing because, all headphone related controls has to be hidden on a fist start, which are IMHO essential for DJing. Hiding them by default may through a bad light on Mixxx. This is the case for the Booth output right now. This is a OK for me, because it is an advanced feature which the user will likely search in hardware preferences. But we can considerer to put the booth gain in the view menu and tell the user how to configure it when he tyres to enable the view. All in all the arguments for "diabling vs. hiding" GUI elements applies, which can be found in various places on the web. |
Commented by: ronso0 I agree with Daniel that hiding headphone controls is not a good solution. However, the dialog should have a Cancel button and respective Preferences pane should not be force-opened (unlike Vinyl or Passthrough buttons react right now). Headphone related controls could be greyed out, Preview deck waveform might have a label saying something like "Headphone device not configured" or graphical equivalent. |
Reported by: h-pa5l-v
Date: 2017-09-10T16:37:17Z
Status: Confirmed
Importance: Low
Launchpad Issue: lp1716249
I'm using an external mixer, with a headphone jack and CUE buttons for headphone cuing. Mixxx's documentation claims that Mixxx can be configured to "External Mixer Mode," in this section from https://www.mixxx.org/manual/latest/chapters/configuration.html:
"External Mixer Mode
In this mode, Mixxx outputs the audio from each deck to a separate soundcard output. This allows you to route the deck outputs through a hardware mixer. To enable external mixer mode, select a valid audio output for the Deck outputs in Preferences ‣ Sound Hardware ‣ Output."
Deck audio is correctly routed through my external mixer and I can use the external mixer for headphone cueing of deck audio. However, I cannot listen to Preview Tracks. They don't get routed to the external mixer.
In External Mixer mode, with Mixxx connected to a 4-in / 4-out soundcard and selecting the soundcard's ch 1-2 and ch 3-4 as DECK 1 and DECK 2, Mixxx does not output Preview Deck audio to the external mixer, but instead seems to still expect a DJ splitter cable to be connected to the PC. I cannot select either of my soundcard's channels as HEADPHONE output in Soundcard Hardware, since Mixxx does not support assigning multiple outputs to a channel.
As a consequence of this functionality, I can not listen to Preview Decks at all through my external mixer, when my hardware is set up correctly for External Mixer mode. Connecting a second pair of headphones to another soundcard output and switching between headphones would theoretically allow me to listen to Preview Decks, but that doesn't seem like a solution.
Steps to reproduce the issue can be added if needed. although the issue seems self explanatory.
The text was updated successfully, but these errors were encountered: