Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong key bindings for hotcues #8949

Closed
mixxxbot opened this issue Aug 23, 2022 · 12 comments
Closed

wrong key bindings for hotcues #8949

mixxxbot opened this issue Aug 23, 2022 · 12 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: foss-4
Date: 2017-10-16T10:42:41Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1723920
Tags: usability


not sure about why this is happening since there were fixes done regarding this problem, documented here:
https://bugs.launchpad.net/mixxx/+bug/1492200

Testing latest nightly as of 2017-10-16 I run into the following situation:

Language is set to german. german apple keyboard looks like this:
https://imgur.com/a/cBFuy

Now the hotcue keyboard shortcuts for the left deck should be "Y, X, C, V" for 1,2,3 and 4.

Currently
Pressing "Y" does nothing. Pressing "Z" does set hotcue 1 (or go to hotcue 1 if it has already been set) and shift Z removes hotcue one.

Expected
Instead of Z when language is set to german, the key for this should be Y.

I opened this new bug, since I am unsure if the problem at hand is at all related to the old bug linked above.

Here are the language settings used in mixxx:
https://imgur.com/a/p1Tl5

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-10-31T20:20:20Z


Is there something reported in your mixxx.log file found at /Users/<username>/Library/Application Support/Mixxx/?

"... not found, using en_US.kbd.cfg"

But the Y key print y in the search box?

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-11-23T23:58:10Z


Hi Daniel, this fell off my radar. Just checked. Lanuage is set to german (germany). When typing the "y" key in the search box prints y and "z" key z and still z sets the first cue point while y does nothing.

I opened mixxx.log. a search for "error" brings up 
Debug [Main]: "Error: Unable to import console: no such extension"
Debug [Main]: "Error: Unable to import svg: no such extension"
Debug [Main]: "Error: Unable to import console: no such extension"
Debug [Main]: "Error: Unable to import svg: no such extension"
Warning [Main]: src/skin/legacyskinparser.cpp:1963 SKIN ERROR at skin:knob_textless.xml:21 <KnobComposed>: Invalid <TooltipId> in skin.xml: "booth_gain"
Warning [Main]: src/skin/legacyskinparser.cpp:1963 SKIN ERROR at skin:knob_textless.xml:21 <KnobComposed>: Invalid <TooltipId> in skin.xml: "booth_gain"

unsure if related to this problem.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2017-11-25T13:22:41Z


Confirmed, looks like there is always the default en_US keyboard layout active, no matter the current locale.

There is no entry in the log about parsing a *.kbd.cfg at all.
maOS 10.11.6  "Mixxx" "2.1.0-alpha-pre" "(git master r6390; built on: Nov 25 2017)

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-12-03T21:44:54Z


I cannot confirm this on a German Ubuntu Trusty using the latest 2.1 alpha
No entry means it actually reads the res/keyboard/de_DE.kbd.cfg
Does Ö work for ch2 cue?

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-12-09T18:45:49Z


Thanks Jus for confirming and Daniel for taking a look at this bug.

Downloaded latest macOS master build from dec 5th. pressing "ö" doesn't do anything for me. sometimes the tracklists jumps to a different position when pressing ö.

While testing I am noticing that the hotcue keys for Deck 2 are broken as well. M and Shift + M for cue 1 work as expected. But cue 2, 3, 4 are not working.

Could it be this bug is limited to macOS?

Daniel if you want access to a mac to take a look, I can offer screensharing as an option.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2018-03-30T11:15:04Z


I will try to test this on a borrowed Mac, although I will only be able to test with an en_US keyboard.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2018-03-30T11:24:46Z


Thanks for having a look at the bug.

You can test with other keyboard layouts by adding other languages in the
macOS System preferences > Keyboard > Input sources

  • Check Show input menu in menu bar

On Mar 30, 2018, at 13:15, Be wrote:

I will try to test this on a borrowed Mac, although I will only be able
to test with an en_US keyboard.

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1723920

Title:
wrong key bindings for hotcues

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1723920/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2018-12-18T11:12:31Z


Tested this again with the latest available 2.2.0-rc (build 2.2 r6638) on macOS 10.14.2 (18C54), and i can NOT confirm this time.

I do think, a lot of the confusion comes from not knowing which keyboard mapping Mixxx actually uses when starting up. There is a debug line missing when loading a default mapping. [1]

So if a user set its system language to EN, but the Mixxx language to DE, it loads up the EN layout. The systems keyboard mapping must explicitly set to EN too. There are possibly many other combinations, since e.g. The Mixxx app language setting is DE, but the Mixxx keyboard language is de_DE , and so on.

[1] https://github.com/mixxxdj/mixxx/blob/master/src/mixxx.cpp#L794

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-03-02T00:08:21Z


Sorry, I do not keep track with what's happening on Launchpad as this bug tracking system is driving me nuts :(

In my case, macOS 10.13.6, Mixxx 2.1.8 and language set to "system" while system is german.

For me this problem is unchanged. pressing "y" which is hotcue 1 does nothing while pressing "z" sets hotcue 1. but that is not correct behaviour for german locale as "YXCV" are expected to be hotcue 1234.

Is this solvable? Another solution is to simply use mixxx in english locale and be done. But then again, it makes no sense to offer other locales if key bindings are then broken.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2019-04-28T07:53:40Z


Just tested again with latest  "Mixxx" "2.3.0-alpha-pre" "(git master r6782; built on: Apr 27 2019 @ 21:23:37) on macos 10.14.3 (german) and it works as expected. Pressing YXCV correctly trigger hotcue 1-4

@foss-4
Please test with the latest Mixxx:
a) The locale your mac is set to.
From the terminal execute defaults read -g AppleLocale, and post the output.
b) start Mixxx in developer mode ./mixxx --developer, and look in the terminal output for a line similar to Found and will use custom keyboard preset or de_DE.kbd.cfg not found, using en_US.kbd.cfg

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-04-28T10:45:28Z


macOS 10.13.6, mixxx 2.3.0-alpha-pre (build master r6782)
verified: works as expected

macOS 10.13.6, mixxx 2.2.1 (build 2.2 r6690)
verified: works as expected

setting milestone to 2.2.1 as that's the first version known to fix this. feel free to also test 2.1.8 and adjust milestone. but I think that download should be hidden on the website or put into a new "old releases" section so not wasting time on testing that.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.2.1 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant