Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyzing file causes sluggish gui #9005

Closed
mixxxbot opened this issue Aug 23, 2022 · 6 comments
Closed

analyzing file causes sluggish gui #9005

mixxxbot opened this issue Aug 23, 2022 · 6 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: poelzi
Date: 2017-12-14T15:41:27Z
Status: Fix Released
Importance: Critical
Launchpad Issue: lp1738227


A regression in the last 2-3 weeks, have not bisected yet.

Selecting a larger amount of tracks and dropping them in analyze will freeze mixxx completely.
Running a track or in general gui feels extremly sluggish now when tracks are analyzed.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2017-12-14T16:33:05Z


I will analyze this issue ASAP now that I noticed it, too!

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2017-12-15T13:43:29Z


Might be caused by a priority inversion between the analysis and the UI thread:
#1413 (comment)

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2017-12-15T13:47:16Z


Some fixes that hopefully improve the situation:
#1413
#1415

We still need to fix the main cause mentioned in the linked PR comment!

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2017-12-16T13:31:49Z


The "sluggish" response is caused by the way how the worker thread communicates with the analyzer component in the main thread. I'll take care of this.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2018-01-14T21:54:35Z


It turned out that the main reason for the unresponsiveness was actually the missing local caching in BaseTrackCache:

#1485

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant