Tango skin - Key and Rate down buttons don't respond to right-click

[mixxxbot]

Reported by: beenisss
Date: 2018-03-01T17:49:58Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1752671
Tags: skin

---

Have tested this in the latest beta and confirmed it only affects Tango and only affects the down buttons, not the up ones.

Steps to reproduce:

• Load the same track to two decks
• Set them both playing and synchronise them
• Right-click and hold on the down button for key or rate on one deck
• Result: Nothing happens
• Compare with doing the same for the up button
• Result: tracks go slowly out of sync/key of selected track is adjusted upward by 10 cents

[mixxxbot]

Commented by: beenisss
Date: 2018-03-01T18:49:31Z

---

In res/skins/Tango/rate_pitch_key.xml, lines 32 and 140 are:
<Template src="skin:button_1state.xml">

I think they should actually be:
<Template src="skin:button_1state_right.xml">

Because otherwise the control only responds to left-click. I've updated and rebuilt my local version and that appears to have fixed it.

[mixxxbot]

Commented by: ronso0
Date: 2018-03-03T14:56:00Z

---

Thanks for reporting this.

Right now I'm fixing & polishing some stuff in Tango #1531
Since you didn't open a PR yet, I will add those changes there.

[mixxxbot]

Issue closed with status Fix Released.