New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: mixxx leaves fullscreen view when switching skins #9343
Comments
Commented by: beenisss Also on macOS, 10.13.6, and I've seen the same thing both in the official release and building directly from source. The default size is pretty small too. I've noticed Mixxx resets the window size if you switch skins while not full-screen too, though obviously it's particularly inelegant if you are in full-screen mode at the time. Additionally, if you quit from full screen, Mixxx reopens with the window at maximum size, but not in a screen of its own. I don't think macOS lets applications open straight to a screen of their own, so all this really does is overwrite the user-determined window size for non-full screen mode. I think the default/recommended behaviour is to always open in a non-maximized window. That's what Safari does at least, which seems a pretty good indicator. Hope I've explained that properly. |
Commented by: beenisss When I build the current 2.3.0 alpha-pre it handles this properly. Not sure if that's because it's been fixed or just a quirk of my system, it seems to have a few. |
Commented by: ronso0 on Linux it fails with 2.3 as well but differently: |
Commented by: uklotzde 2.2 + XWayland + Full-screen view: Ok 2.2 + XWayland + Window view: (Ok) |
Commented by: JosepMaJAZ Windows 10: Mixxx 2.2 built from sources this weekend. Things works as expected as in: When in fullscreen and switching skins, it temporarily switches to windowed mode, and when the skin is loaded it goes back into fullscreen. Could it be that this "switching on/off" of the fullscreen mode causes it to not enter fullscreen in some circumstances? What I've observed in the other bug at #1773587 is that when used in maximized state it does what is reported here. But maximized is not the same as fullscreen. |
Commented by: beenisss I said this in an earlier comment:
I suspect I mis-stated the case. I currently get the issue with all builds and releases. The only thing different is that the official release doesn't restore to a maximized window properly, whereas the beta and any build from a recent master do. |
Commented by: beenisss I don't think this is the same issue as #1773587 |
Commented by: daschuer Ups .. Thank you. |
Commented by: foss-4 Is this issue on the radar for 2.2.1 indeed? Is there a PR already? Is there a dev willing to work on this? |
Commented by: ronso0 btw: skins are also shown at minimal size after (re)loading skins in windowed mode although Mixxx fills the screen. |
Commented by: ronso0 another observation (ubuntu studio, X11): window with custom size > reload skin = window at minimal size (set by skin) some hopefully helpful input before I work on it myself: maybe we should do this when reloading the main window:
|
Commented by: foss-4 This problem is unchanged. Is anybody willing to look into this? Seems like various OS are affected. Functionality is not decreased but it's somewhat annoying to have windows jump around and switch size by themselves. |
Commented by: daschuer I can confirm this. |
Commented by: foss-4 Sorry, not fixed on macOS. Still leaving full-screen when switching skin. |
Commented by: foss-4 yup, original report was filed against macOS so let's leave this bug open. |
Commented by: ronso0 @foss-4 Is the issue still in 2.3? |
Commented by: foss-4 unchanged and persisting |
Commented by: foss-4 Goes back to window mode after skin switch testing 2.3-beta-3983-g674fc8ceee (HEAD branch) (from this PR) on macOS 11.3.1. Oh and thanks very much for looking into this. ❤️ |
Issue closed with status Won't Fix. |
Reported by: foss-4
Date: 2018-06-17T14:30:10Z
Status: Won't Fix
Importance: Medium
Launchpad Issue: lp1777328
Tags: macos
macOS 10.13.5
mixxx-2.2.0-alpha-pre-master-git6517-release-macintel64.dmg
Reproducible: always
Currently
Switch skins and you'll find yourself in window mode
Expected
stay in fullscreen mode
The text was updated successfully, but these errors were encountered: