Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move End-Of-Track blinking to overviews exclusively #9648

Open
mixxxbot opened this issue Aug 23, 2022 · 1 comment · May be fixed by #4337
Open

move End-Of-Track blinking to overviews exclusively #9648

mixxxbot opened this issue Aug 23, 2022 · 1 comment · May be fixed by #4337

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2019-05-01T14:44:42Z
Status: In Progress
Importance: Undecided
Launchpad Issue: lp1827221
Tags: gui, waveform


as discussed in lp:1204294

jus:
I think the end of track warning does not belong to the main waveform at all, it is pretty redundant there.

Currently we display
a) A blinking gradient on the background of the main waveform
b) a static rectangle on the background of the waveform overview.

The end of track warning should go as blinking rectangle exclusively to the waveform overview. Saves performance on the main waveform, while being always prominently visible on the waveform overview.

ronso0:
I agree, there should be a blinking rectangle in the overview. Now, that we have 3 skins where the scrolling waveforms can be hidden it's easy to miss the warning.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-09-29T13:21:40Z


#4337

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
@daschuer daschuer linked a pull request May 31, 2023 that will close this issue
2 tasks
@ronso0 ronso0 removed this from the 2.4.0 milestone Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants