Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaleMoon contrast, SVG optimize, small fixes #3835

Merged
merged 6 commits into from May 11, 2021
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 6, 2021

  • BPM Tap button now spans BPM and rate% (and matches previous hover highlight)
  • picking up @Holzhaus's inspiration we now have a pale logo
    image
    image

@github-actions github-actions bot added the skins label May 6, 2021
@ronso0 ronso0 added this to In progress in 2.3 release via automation May 6, 2021
@ronso0 ronso0 added this to the 2.3.0 milestone May 6, 2021
@ronso0
Copy link
Member Author

ronso0 commented May 6, 2021

  • Windows: remove useless dotted focus border from effect selector and AutoDJ mode selector

@Holzhaus
Copy link
Member

Holzhaus commented May 7, 2021

Thanks.

Just a minor note: I think it would look better if there were less different shades of grey in the toolbar. Could we use #444444 or #A89A8C instead of #746658 (like the battery icon and the clock)?

@ronso0
Copy link
Member Author

ronso0 commented May 7, 2021

I'll test that

@ronso0
Copy link
Member Author

ronso0 commented May 10, 2021

the small logo is now painted d like the charged battery, please take a look.

  • Windows: remove useless dotted focus border from effect selector and AutoDJ mode selector

nice to have, doesn't block this PR though.

@Holzhaus
Copy link
Member

Awesome, thank you!

@Holzhaus Holzhaus merged commit 4992322 into mixxxdj:2.3 May 11, 2021
2.3 release automation moved this from In progress to Done May 11, 2021
@ronso0 ronso0 deleted the late-tap branch May 11, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
2.3 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants