Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build PortAudio with JACK support #20

Merged
merged 3 commits into from
Aug 1, 2021
Merged

build PortAudio with JACK support #20

merged 3 commits into from
Aug 1, 2021

Conversation

Be-ing
Copy link

@Be-ing Be-ing commented Jul 31, 2021

No description provided.

@Be-ing Be-ing mentioned this pull request Jul 31, 2021
Merged
@Be-ing
Copy link
Author

Be-ing commented Jul 31, 2021

I have tested this and it builds on macOS too 😄 https://github.com/Be-ing/vcpkg/runs/3210867320

@Be-ing
Copy link
Author

Be-ing commented Jul 31, 2021

Note this will require changing our FindPortAudio.cmake module in Mixxx to export the target as PortAudio::PortAudio.

@Be-ing Be-ing requested review from daschuer and Holzhaus July 31, 2021 22:42
daschuer
daschuer approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer
Copy link
Member

Waiting for CI.

On the long run, cloning from a private Repro is not the best way forward.
How is the status to get this merged upstream?

If this is not possible, we should consider to fork you repro at mixxxdj, or add your changes to the vcpkg port folder.

@Be-ing
Copy link
Author

Be-ing commented Jul 31, 2021

PortAudio/portaudio#461 is just waiting for final approval. I hope that will be in the next few days.

Be-ing added a commit to Be-ing/mixxx that referenced this pull request Aug 1, 2021
@Be-ing
CMake: make FindPortAudio.cmake module export PortAudio::PortAudio
799506f 
to match targets exported by config files
PortAudio/portaudio#461
mixxxdj/vcpkg#20
Be-ing added a commit to Be-ing/mixxx that referenced this pull request Aug 1, 2021
@Be-ing
CMake: make FindPortAudio.cmake module export PortAudio::PortAudio
9be6fdb 
to match targets exported by config files
PortAudio/portaudio#461
mixxxdj/vcpkg#20
@Be-ing Be-ing mentioned this pull request Aug 1, 2021
Merged
@Be-ing
Copy link
Author

Be-ing commented Aug 1, 2021

CI passed

@Be-ing Be-ing merged commit 4a9c13c into mixxxdj:2.4 Aug 1, 2021
@Be-ing
Copy link
Author

Be-ing commented Aug 1, 2021

By the way I opened a PR to update JACK upstream: microsoft#19270

@Be-ing Be-ing deleted the portaudio-jack branch August 1, 2021 03:40
@Be-ing
Copy link
Author

Be-ing commented Aug 1, 2021

Oops I should have checked the build log...

-- Could NOT find JACK (missing: JACK_LIBRARY)

@Be-ing
Copy link
Author

Be-ing commented Aug 1, 2021 •
edited
Loading

The failure to find JACK is not a bug in this port. The bug is that the jack2 port did not install the pkgconfig file. I have opened a PR to fix this and update JACK upstream: microsoft#19270 I tested uninstalling system JACK packages, building that updated port, then building this portaudio port and I confirmed in the logs that the portaudio port builds with JACK.

@Be-ing Be-ing mentioned this pull request Aug 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@github-actions github-actions[bot] github-actions approved these changes

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Be-ing @daschuer