Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshots #126

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Update screenshots #126

merged 2 commits into from
Jul 23, 2020

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus requested a review from ronso0 July 15, 2020 10:49
@Holzhaus
Copy link
Member Author

Ready to merge!

@katsar0v
Copy link
Contributor

Looks fine to me. I guess we will need to update the website as soon as 2.3 stable is out, because the current screenshots are from 2.2 stable?

@ronso0
Copy link
Member

ronso0 commented Jul 18, 2020

I'd omit skin in the captions and instead write Here you can find some screenshots of Mixxx' user interface, so called 'skins'.

Then we can have for example Shade, Classic theme or just Shade Classic.

@ronso0
Copy link
Member

ronso0 commented Jul 18, 2020

tbh it's been a while that I looked at the screenshots on the website.
Looking at the Shade screenshots taken with 4k will raise some questions about the layout:
why is there so much whitespace in the decks? why is there an extra row for the hotcues? why is so much space wasted for the library cover art? ...

I think we should take the screenshots with a resolution close to that each skin was designed for. Like, when the minimum size is 1024px we can take a screenshot with either 1024px or 1280px.
(temporarily changing the minimum size to the desired resolution instead of manually resizing the window..)

@Holzhaus
Copy link
Member Author

@katsar0v

Looks fine to me. I guess we will need to update the website as soon as 2.3 stable is out, because the current screenshots are from 2.2 stable?

With this PR the screenshot page features both screenshots from 2.2 and 2.3. Check out the deploy preview.

@ronso0

I'd omit skin in the captions and instead write Here you can find some screenshots of Mixxx' user interface, so called 'skins'.

Then we can have for example Shade, Classic theme or just Shade Classic.

Hmm, I tried to make that sentence generic because I do think we should add some screenshots of other parts of Mixxx, too (e.g. the preferences). When I check out the website of a software, I always look for screenshots of the settings to see if I can customize it to my needs. Didn't do it in the PR because my GTK theme is ugly.

tbh it's been a while that I looked at the screenshots on the website.
Looking at the Shade screenshots taken with 4k will raise some questions about the layout:
why is there so much whitespace in the decks? why is there an extra row for the hotcues? why is so much space wasted for the library cover art? ...

Yes, I don't know why the library cover art is in a vertical column in Shade.

I think we should take the screenshots with a resolution close to that each skin was designed for. Like, when the minimum size is 1024px we can take a screenshot with either 1024px or 1280px.
(temporarily changing the minimum size to the desired resolution instead of manually resizing the window..)

I tried to make all screenshots as similar as possible, i.e. with the same knob/fader settings, the same resolution, roughly the same library view, etc. to make them comparable.

I think we can merge this as is.

@ronso0 ronso0 linked an issue Jul 23, 2020 that may be closed by this pull request
@ronso0
Copy link
Member

ronso0 commented Jul 23, 2020

Hmm, I tried to make that sentence generic because I do think we should add some screenshots of other parts of Mixxx, too (e.g. the preferences). When I check out the website of a software, I always look for screenshots of the settings to see if I can customize it to my needs. Didn't do it in the PR because my GTK theme is ugly.

Yup, good idea!

#132
#133

@ronso0 ronso0 merged commit c223ee3 into mixxxdj:website Jul 23, 2020
@ywwg
Copy link
Member

ywwg commented Jul 24, 2020

Hi, thanks for making this change. Can we choose a different track for the first deck than one by "Joey Negro"? As part of our work to change nomenclature (https://mixxx.org/news/2020-06-29-black-lives-matter/), it's a bad look to include an artist with a name that he has specifically said he will stop using due to its offensive nature: https://www.nme.com/news/music/joey-negro-announces-hes-dropped-his-stage-name-2713005

Sorry I didn't catch this before merge.

@Holzhaus
Copy link
Member Author

Whoops, sorry, just took a random track from my library. I'm busy tomorrow, I can file a new PR on Sunday.

@ywwg
Copy link
Member

ywwg commented Jul 24, 2020

is it ok if we revert this PR for now? I know it's unlikely anyone will notice but I'd like not to trip on this quite so soon after the post :)

@ywwg
Copy link
Member

ywwg commented Jul 24, 2020

And no worries! I assumed it was an honest mistake. I've got that hat on so I'm on the lookout for it.

@Holzhaus
Copy link
Member Author

I know it's unlikely anyone will notice but I'd like not to trip on this quite so soon after the post :)

Yeah, that would be embarassing :D

I just realized this only affects the 2.3 screenshots. Make a new PR just about now. Gimme a few minutes.

@Holzhaus
Copy link
Member Author

@ywwg In case you didn't see it: #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screenshot links are small
4 participants