-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update screenshots #126
Update screenshots #126
Conversation
b19bf87
to
6900a2b
Compare
Ready to merge! |
Looks fine to me. I guess we will need to update the website as soon as 2.3 stable is out, because the current screenshots are from 2.2 stable? |
I'd omit Then we can have for example |
tbh it's been a while that I looked at the screenshots on the website. I think we should take the screenshots with a resolution close to that each skin was designed for. Like, when the minimum size is 1024px we can take a screenshot with either 1024px or 1280px. |
With this PR the screenshot page features both screenshots from 2.2 and 2.3. Check out the deploy preview.
Hmm, I tried to make that sentence generic because I do think we should add some screenshots of other parts of Mixxx, too (e.g. the preferences). When I check out the website of a software, I always look for screenshots of the settings to see if I can customize it to my needs. Didn't do it in the PR because my GTK theme is ugly.
Yes, I don't know why the library cover art is in a vertical column in Shade.
I tried to make all screenshots as similar as possible, i.e. with the same knob/fader settings, the same resolution, roughly the same library view, etc. to make them comparable. I think we can merge this as is. |
Yup, good idea! |
Hi, thanks for making this change. Can we choose a different track for the first deck than one by "Joey Negro"? As part of our work to change nomenclature (https://mixxx.org/news/2020-06-29-black-lives-matter/), it's a bad look to include an artist with a name that he has specifically said he will stop using due to its offensive nature: https://www.nme.com/news/music/joey-negro-announces-hes-dropped-his-stage-name-2713005 Sorry I didn't catch this before merge. |
Whoops, sorry, just took a random track from my library. I'm busy tomorrow, I can file a new PR on Sunday. |
is it ok if we revert this PR for now? I know it's unlikely anyone will notice but I'd like not to trip on this quite so soon after the post :) |
And no worries! I assumed it was an honest mistake. I've got that hat on so I'm on the lookout for it. |
Yeah, that would be embarassing :D I just realized this only affects the 2.3 screenshots. Make a new PR just about now. Gimme a few minutes. |
No description provided.