Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New in 2.3: Add Serato post #81

Merged
merged 16 commits into from
Feb 8, 2021
Merged

New in 2.3: Add Serato post #81

merged 16 commits into from
Feb 8, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented May 6, 2020 •
edited
Loading

This is still a WIP.

@Holzhaus Holzhaus added the news News posts label May 6, 2020
@Holzhaus Holzhaus mentioned this pull request May 6, 2020
Open
sblaisot
sblaisot reviewed May 7, 2020
View reviewed changes
pages/news/2020-XX-XX-new-in-2-3-serato-support.html Outdated
That way, you can start using your loops once 2.4 is out without the need to reimport your metadata (which would undo your cue modifications in Mixxx).

Other Serato metadata that we parse include the track color and the BPM lock status.
Serato also stores other information like the overview waveform image and the beatgrid in the file tags, but we don't import that information in Mixxx 2.3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...import these information... I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original sentence is correct?

@Be-ing
Copy link
Contributor

Be-ing commented May 7, 2020

Welcome back @sblaisot :)

@sblaisot
Copy link
Member

sblaisot commented May 7, 2020

Welcome back @sblaisot :)

👋
I still take a look at mixxx evolution from time to time.
This time I was looking at this PR ;)

@Holzhaus Holzhaus mentioned this pull request Dec 10, 2020
Merged
@Holzhaus Holzhaus marked this pull request as ready for review January 14, 2021 12:32
@ywwg
Copy link
Member

ywwg commented Jan 20, 2021

please update the XX-XX date to today's date

@Holzhaus
Copy link
Member Author

Holzhaus commented Jan 20, 2021 •
edited
Loading

It is updated automatically by CI post merge since #166

@Holzhaus
Copy link
Member Author

Holzhaus commented Feb 5, 2021

@ywwg Merge?

@ywwg
Copy link
Member

ywwg commented Feb 6, 2021

oh sorry I didn't realize the date would be automatically added. I'm going to wait to merge this because we just merged a bunch of Deborah's posts. Is monday ok? I'll put it in my calendar so I don't forget

@Holzhaus
Copy link
Member Author

Holzhaus commented Feb 6, 2021

Ok.

@ywwg ywwg merged commit 27a62bb into mixxxdj:website Feb 8, 2021
@Holzhaus
Copy link
Member Author

Holzhaus commented Feb 8, 2021

@ywwg looks like something broke in the date update script. I'm investigating.

@Holzhaus
Copy link
Member Author

Holzhaus commented Feb 8, 2021

Ok, after verifying locally I pushed my fixes upstream directly (sorry for that, but the proof of the pudding is in the eating).

It worked: https://github.com/mixxxdj/website/runs/1856831250?check_suite_focus=true
Here's the resulting commit: f004125

@ywwg
Copy link
Member

ywwg commented Feb 9, 2021

thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sblaisot sblaisot sblaisot left review comments

@ronso0 ronso0 ronso0 left review comments

@ninomp ninomp ninomp left review comments

@Be-ing Be-ing Be-ing left review comments

Assignees
No one assigned
Labels
news News posts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Holzhaus @Be-ing @sblaisot @ywwg @ronso0 @ninomp