New in 2.3: Add Rekordbox post #88

ehendrikd · 2020-05-13T13:51:17Z

With screenshots added, this should be ready to merge.

mixxx-buildbot · 2020-05-13T13:51:19Z

Can one of the admins verify this patch?

Say: "add to whitelist" to add this user to the whitelist for future PRs.
Say: "ok to test" to start a Jenkins build.
Say: "skip ci" to skip the Jenkins build.
Say: "test this please" to trigger a re-build.

Be-ing · 2020-05-13T14:27:30Z

add to whitelist

Holzhaus

Awesome, thanks!

I fixed the markup in some places and added some comments.

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Co-authored-by: Be <be.0@gmx.com>

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

Co-authored-by: Be <be.0@gmx.com>

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

Be-ing · 2020-07-13T01:41:45Z

Could you use the full resolution screenshots? 636px × 368px screenshots look quite blurry on my 3840 x 2160 screen.

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

Co-authored-by: Be <be.0@gmx.com>

Be-ing · 2020-07-13T02:52:34Z

Looks good to me! @Holzhaus any last comments?

Swiftb0y

There are still two TODO sections we should remove / fill in.

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

Swiftb0y · 2020-07-13T09:41:44Z

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

+
+<div style="text-align: center;"><img src="{% static '/static/images/news/rekordbox-6-usb.png' %}" /><img src="{% static '/static/images/news/mixxx-rekordbox-usb.png' %}" /></div>
+
+Also note that as with the Serato library feature{# TODO: Add link to serato blogpost #}, we have tried our best to mitigate against certain edge cases of audio files encoded in lossy formats (MP3 and AAC/MP4), where different software's decoders can interpret conflicting timing information, leading to shifted cue points and beatgrids. We hope these are all correct, but some cases may be milliseconds off, and if you find any of these, please let us know on [Zulip](https://mixxx.zulipchat.com).


Also contains a TODO

Serato news post hasn't been published yet so unfortunately don't have a link to update with.

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

Be-ing · 2020-07-14T21:09:46Z

Thanks @ehendrikd!

Holzhaus · 2020-07-14T21:14:20Z

Let's not merge all posts at once. We should leave a few days between each of them. Also, the post still containrd some TODOs. Revert?

Holzhaus · 2020-07-14T22:38:48Z

Ping

…dbox-removable-devices" This reverts commit db75cc1, reversing changes made to 7960a91.

Holzhaus · 2020-07-14T22:45:02Z

I revert the merge, would be shame if this post doesn't get the publicity it deserves.

…-3-rekordbox-removable-devices"" This reverts commit 68abb13.

ehendrikd · 2020-07-14T23:22:42Z

The remaining TODO links to the Serato post, so assume it would need to be published first, then this can be updated.

Be-ing · 2020-07-15T08:17:32Z

I don't think there was any need to revert this.

ehendrikd added 2 commits May 12, 2020 21:30

Add ehendrikd as author

9fbda08

1st draft 2.3 Rekordbox removable device support

a84b72a

ehendrikd mentioned this pull request May 13, 2020

Announcements for the 2.3 release #77

Open

Holzhaus requested changes May 13, 2020

View reviewed changes

Be-ing reviewed May 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

ehendrikd and others added 7 commits May 14, 2020 10:16

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

15f008e

Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

6872934

Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

0010e19

Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

31cdafa

Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

123eccd

Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

4ddc2ac

Co-authored-by: Be <be.0@gmx.com>

Address feedback

6e6b599

Be-ing reviewed May 15, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 15, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 15, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 15, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 15, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Show resolved Hide resolved

ehendrikd and others added 5 commits May 19, 2020 21:24

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

bab9e9b

Co-authored-by: Be <be.0@gmx.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

ac401ac

Co-authored-by: Be <be.0@gmx.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

b645b7b

Co-authored-by: Be <be.0@gmx.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

316d159

Co-authored-by: Be <be.0@gmx.com>

Address feedback, add CDJ HID info

7fc358a

Be-ing reviewed May 19, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 19, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed May 19, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed Jul 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed Jul 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed Jul 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Be-ing reviewed Jul 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Full res screenshots

d859a35

Be-ing reviewed Jul 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

ehendrikd and others added 6 commits July 13, 2020 11:54

Adjust beatgrid screenshot

65de8c9

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

e35f365

Co-authored-by: Be <be.0@gmx.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

4a5f635

Co-authored-by: Be <be.0@gmx.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

25fff55

Co-authored-by: Be <be.0@gmx.com>

Update pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html

c022490

Co-authored-by: Be <be.0@gmx.com>

Update list

f7e7a89

ehendrikd marked this pull request as ready for review July 13, 2020 02:25

Be-ing self-requested a review July 13, 2020 02:52

Be-ing approved these changes Jul 13, 2020

View reviewed changes

Swiftb0y requested changes Jul 13, 2020

View reviewed changes

Holzhaus requested changes Jul 13, 2020

View reviewed changes

pages/news/2020-XX-XX-new-in-2-3-rekordbox-support.html Outdated Show resolved Hide resolved

Change HTML images to markdown, update TODO

3c3876b

Be-ing merged commit db75cc1 into mixxxdj:website Jul 14, 2020

Holzhaus added a commit to Holzhaus/mixxx-website that referenced this pull request Jul 14, 2020

Revert "Merge pull request mixxxdj#88 from ehendrikd/new-in-2-3-rekor…

68abb13

…dbox-removable-devices" This reverts commit db75cc1, reversing changes made to 7960a91.

Holzhaus added a commit to Holzhaus/mixxx-website that referenced this pull request Jul 14, 2020

Revert "Revert "Merge pull request mixxxdj#88 from ehendrikd/new-in-2…

8baeba8

…-3-rekordbox-removable-devices"" This reverts commit 68abb13.

Holzhaus mentioned this pull request Jul 14, 2020

New in 2.3: Rekordbox removable library #125

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New in 2.3: Add Rekordbox post #88

New in 2.3: Add Rekordbox post #88

ehendrikd commented May 13, 2020 •

edited

Loading

mixxx-buildbot commented May 13, 2020

Be-ing commented May 13, 2020

Holzhaus left a comment

Be-ing commented Jul 13, 2020

Be-ing commented Jul 13, 2020

Swiftb0y left a comment

Swiftb0y Jul 13, 2020

ehendrikd Jul 13, 2020

Be-ing commented Jul 14, 2020

Holzhaus commented Jul 14, 2020 •

edited

Loading

Holzhaus commented Jul 14, 2020

Holzhaus commented Jul 14, 2020

ehendrikd commented Jul 14, 2020

Be-ing commented Jul 15, 2020


		<div style="text-align: center;"><img src="{% static '/static/images/news/rekordbox-6-usb.png' %}" /><img src="{% static '/static/images/news/mixxx-rekordbox-usb.png' %}" /></div>

		Also note that as with the Serato library feature{# TODO: Add link to serato blogpost #}, we have tried our best to mitigate against certain edge cases of audio files encoded in lossy formats (MP3 and AAC/MP4), where different software's decoders can interpret conflicting timing information, leading to shifted cue points and beatgrids. We hope these are all correct, but some cases may be milliseconds off, and if you find any of these, please let us know on [Zulip](https://mixxx.zulipchat.com).

New in 2.3: Add Rekordbox post #88

New in 2.3: Add Rekordbox post #88

Conversation

ehendrikd commented May 13, 2020 • edited Loading

mixxx-buildbot commented May 13, 2020

Be-ing commented May 13, 2020

Holzhaus left a comment

Choose a reason for hiding this comment

Be-ing commented Jul 13, 2020

Be-ing commented Jul 13, 2020

Swiftb0y left a comment

Choose a reason for hiding this comment

Swiftb0y Jul 13, 2020

Choose a reason for hiding this comment

ehendrikd Jul 13, 2020

Choose a reason for hiding this comment

Be-ing commented Jul 14, 2020

Holzhaus commented Jul 14, 2020 • edited Loading

Holzhaus commented Jul 14, 2020

Holzhaus commented Jul 14, 2020

ehendrikd commented Jul 14, 2020

Be-ing commented Jul 15, 2020

ehendrikd commented May 13, 2020 •

edited

Loading

Holzhaus commented Jul 14, 2020 •

edited

Loading