Fix a small bug with multiple selectors #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog diff is:
Conflicts: Changes
arc
pushed a commit
to arc/HTML-Selector-XPath
that referenced
this pull request
Jan 20, 2015
Added repository cpan metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
I found two small bugs - first, comma-separated selectors with whitespace, like
a , p
didn't get interpreted correctly, and second,
foo , :root
didn't get interpreted correctly. This series of patches brings the module to v0.07 and adds tests and fixes for these bugs.
I hope my merge back to the main tree was OK and didn't confuse Github. Otherwise, I can wipe my repo and rebase onto your tree. But as the Network Graph shows the branches merging again, everything should Just Work.
-max