Net::Server has support for Log4perl, which means by extension that Star... #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tarman could have it as well. However, Starman doesn't pass the options down to Net::Server that it needs. This patch adds those.
|
bump Anything we can do to get this into a new version? |
|
This would be addressed by #109. |
|
agree @ap - rather than adding every single option mapped in Starman, I would have a generic way to pass Net::Server options in one shot :) |
|
That works for me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...man could have it as well. However, Starman doesn't pass the options down to Net::Server that it needs. This patch adds those. Thanks in advance for your consideration.
--Andrew