Ensure that chunk buffer contains terminating HTTP newline #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sysread() returns content just short of the termination HTTP newline, then the content of the chunk is removed from $chunk_buffer while eventually leaving the HTTP newline. This breaks the invariant that $chunk_buffer will always start with the size of the next chunk.
|
Can you write a unit test to verify the fix? |
miyagawa
added a commit
that referenced
this pull request
Mar 15, 2012
Ensure that chunk buffer contains terminating HTTP newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sysread() returns content just short of the termination HTTP newline, then
the content of the chunk is removed from $chunk_buffer while eventually
leaving the HTTP newline. This breaks the invariant that $chunk_buffer will
always start with the size of the next chunk.