Fix bug where Twiggy's run loop exits after a streaming request is cut off #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twiggy (as of version 0.1024) shuts down after servicing a request that writes streaming contents to a PSGI writer, and the connection is broken.
|
@miyagawa Have you had a chance to look at this? |
|
@miyagawa If you have time, would you mind taking a look at this change? |
miyagawa
added a commit
that referenced
this pull request
Jan 3, 2015
Fix bug where Twiggy's run loop exits after a streaming request is cut off
|
sorry that it's taken such a long time. I don't really understand the fix, but sounds trivial enough to merge. |
|
No problem, I had forgotten about it myself. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found a bug in Twiggy where if you're using a streaming writer and the client stops the request, the PSGI application dies in such a way that Twiggy itself shuts down. A test file and fix are included. The fix isn't the cleanest, but maybe it's a starting point you could improve upon!
-Rob