Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cpanfile extra args #11

Merged
merged 5 commits into from
Apr 14, 2013
Merged

Conversation

masaki
Copy link
Contributor

@masaki masaki commented Apr 13, 2013

requires 'Plack';
requires 'Plack', '0.9970';
requires 'Plack', git => 'git://github.com/plack/Plack.git', revision => '0.9970';
requires 'Plack', '0.9970', git => 'git://github.com/plack/Plack.git', revision => '0.9970';

# and

requires 'git://github.com/plack/Plack.git';
requires 'git://github.com/plack/Plack.git@0.9970';

are okay.

@miyagawa
Copy link
Owner

I think requires 'git-URL' should not be OK.

@miyagawa
Copy link
Owner

I just pushed a new changes for 'feature' and it will probably conflict with your changes. Can you rebase and fix conflicts? Sorry about that.

@masaki
Copy link
Contributor Author

masaki commented Apr 13, 2013

okay, changes are following:

  • drop requires 'git-URL' pattern
  • merge from feature (master)

@miyagawa
Copy link
Owner

will take a look at this tomorrow.

miyagawa added a commit that referenced this pull request Apr 14, 2013
@miyagawa miyagawa merged commit 3f3a58f into miyagawa:master Apr 14, 2013
@miyagawa
Copy link
Owner

Looks good, but i wonder what the API should look like for the carton/cpanm usage.

CPAN::Meta::Prereqs loses the information for this, but we need to somehow restore this information when dumping to 02packages etc.

@masaki
Copy link
Contributor Author

masaki commented Apr 14, 2013

Yes, it sounds difficult...

@masaki
Copy link
Contributor Author

masaki commented Apr 14, 2013

@miyagawa
Copy link
Owner

Nice.

We talked about changing the 02packages format to embed git URL there, rather than A/AU/AUTHOR/Dist-Name-ver.tar.gz - that's rather a bigger change, but this way we can handle this for not just direct target but dependencies as well.

miyagawa added a commit that referenced this pull request Apr 16, 2013
This reverts commit 3f3a58f, reversing
changes made to 56863c6.

Conflicts:
	t/requirement.t
miyagawa added a commit that referenced this pull request Sep 19, 2013
This reverts commit 5c5e3f5.

Conflicts:
	lib/Module/CPANfile.pm
@tokuhirom
Copy link

What's the current status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants