dedupe flattened deps after version check. Fixes gh-32

miyagawa · Apr 10, 2010 · 76d73a9 · 76d73a9
1 parent 2dd182b
commit 76d73a9
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/lib/App/cpanminus/script.pm b/lib/App/cpanminus/script.pm
@@ -882,12 +882,13 @@ sub should_install {
 sub install_deps {
     my($self, $dir, $depth, @deps) = @_;
 
-    my %deps = @deps; # XXX
-
-    my @install;
-    while (my($mod, $ver) = each %deps) {
-        next if $mod eq 'perl' or $mod eq 'Config';
-        push @install, $self->should_install($mod, $ver);
+    my(@install, %seen);
+    while (my($mod, $ver) = splice @deps, 0, 2) {
+        next if $seen{$mod} or $mod eq 'perl' or $mod eq 'Config';
+        if ($self->should_install($mod, $ver)) {
+            push @install, $mod;
+            $seen{$mod} = 1;
+        }
     }
 
     if (@install) {