fix(notifications): remove a option for last notified time

miyajan · Jan 5, 2017 · 14d04de · 14d04de
1 parent 0df1056
commit 14d04de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/index.js b/index.js
@@ -27,16 +27,15 @@ class VersionEyeSlack {
 
     /**
      * Post notifications of VersionEye to Slack
-     * @param {!Date} opt_lastNotifiedTime Post only notifications created after the specific time
      * @return {!Promise}
      */
-    postNotifications(opt_lastNotifiedTime) {
+    postNotifications() {
         return this._versioneye.me.listNotifications().then(json => {
             const attachments = [];
             json['notifications'].forEach(notification => {
                 const createdAt = Date.parse(notification['created_at']);
-                if (opt_lastNotifiedTime && opt_lastNotifiedTime > createdAt) {
-                    // already notified
+                if (notification['read']) {
+                    // already read
                     return;
                 }
                 const productKey = notification['product']['prod_key'];

diff --git a/lib/cli.js b/lib/cli.js
@@ -69,25 +69,14 @@ function main(argv, env, exit) {
 
     program.command('notifications')
         .description('Post notifications of VersionEye to Slack')
-        .option('--last-notified-time <dateString>', 'Post only notifications created after the time')
         .action(options => {
             if (program.args.length !== 1) {
                 // any unknown arguments
                 printHelpAndExit(exit);
             }
 
             const versioneyeSlack = setupVersioneyeSlack(options, env, exit);
-
-            let lastNotifiedTime;
-            if (options.lastNotifiedTime) {
-                lastNotifiedTime = Date.parse(options.lastNotifiedTime);
-                if (!lastNotifiedTime) {
-                    console.error(options.lastNotifiedTime + ' can not be parsed. Use ISO 8601 syntax.');
-                    exit(1);
-                }
-            }
-
-            versioneyeSlack.postNotifications(lastNotifiedTime).then(response => {
+            versioneyeSlack.postNotifications().then(response => {
                 console.log(response);
             }).catch(err => {
                 console.error(err.message);