Compatibility fixes for docutils, mistune, argparse #67
Conversation
- Replace the `ErrorString` symbol with `io.error_string`, see also [1]. - Lose the `SafeString` usage, which is no longer necessary in Python 3. [1] - Add compatibility with docutils 0.19, which removed the deprecated symbols `ErrorString` and `SafeString`. [1] - Drop support for Python 2.7, 3.4, 3.5, and 3.6 because docutils 0.19 requires Python 3.7 or newer. [2] - Sync up assertion with changes in argparse [1]: https://sourceforge.net/p/docutils/code/8937/ [2]: https://sourceforge.net/projects/docutils/files/docutils/0.19/
See also [1]. [1]: lepture/mistune#291 (comment)
|
Related: CrossNox#49 |
|
Why not just update mistune 2.x? 🤔 |
|
@kloczek That would require a bit of work due to the breaking API. |
|
Old mistune 1.x is no longer maintained so it is only matter of time when it will be necessary to do that. |
|
@kloczek You’re not wrong. If someone steps up and makes it all work with mistune v2, I’ll happily withdraw this PR. But I’m not really invested in doing all the work myself. Actually, I don’t even use m2r. I’m just a humble package maintainer, who meant to contribute a small patch upstream. |
|
As a user hitting these issues with |
|
Can we please merge this and worry about a way forward once this is no longer and breaking issue? |
The following compatibility fixes are required to make m2r work with the current Python ecosystem:
Add compatibility with docutils 0.19 (see commit message for details)
Require Python 3.7+ due to constraints in docutils 0.19
Sync up assertion with changes in argparse
Limit mistune dependency version range (details)