Add a support for object as second arg of map helpers. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Masa-Shin
commented
May 23, 2022
| throw new Error( | ||
| "Function value in a map object is not currently supported." | ||
| ); | ||
| } |
There was a problem hiding this comment.
Due to lack of time, the case where the value of an object is a function is not done. I will do it if the PR is merged.
Masa-Shin
force-pushed
the
add-support-for-map-object
branch
from
a7d11e5
to
f9f5f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapState and mapGetters can receive an object as second argument but the converter does not support this notation and just remove them without notice. I add a support for the notation as long as the values of the passed object are strings. For the case values are functions, it just throw an error at the time. I will fix it after the PR is merged.