Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second round of updates in reaction to JOSS review #107

Merged
merged 8 commits into from Feb 22, 2019

Conversation

miykael
Copy link
Owner

@miykael miykael commented Feb 20, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #107 into master will decrease coverage by 0.19%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #107     +/-   ##
=========================================
- Coverage   87.87%   87.68%   -0.2%     
=========================================
  Files           6        6             
  Lines         404      414     +10     
=========================================
+ Hits          355      363      +8     
- Misses         49       51      +2
Impacted Files Coverage Δ
atlasreader/__init__.py 100% <ø> (ø) ⬆️
atlasreader/tests/test_cli.py 100% <ø> (ø) ⬆️
atlasreader/cli.py 0% <0%> (ø) ⬆️
atlasreader/tests/test_atlasreader.py 100% <100%> (ø) ⬆️
atlasreader/atlasreader.py 95.41% <87.5%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1fa58...b2fdb8d. Read the comment docs.

@miykael
Copy link
Owner Author

miykael commented Feb 22, 2019

All tests passed. Ready to merge.

@miykael miykael merged commit c0a3225 into master Feb 22, 2019
@miykael miykael deleted the joss_review_feedback_2 branch February 22, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants