[MAINT] run test and flake8 github actions #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Remi-Gau
commented
Aug 30, 2023
•
Remi-Gau
commented
- upload coverage report
- make sure tests pass
- rm travis.yml
- add GHA workflow
- add test data instead of downloading from neurovault to minimize failures
- add pre-commit to run flake8 locally upon commit
- closes run tests on github action instead of travis #125, run flake8 via github action instead of travis #126
- closes fix broken badge in readme #129
Remi-Gau
commented
Aug 30, 2023
|
not sure why we are getting this: https://github.com/miykael/atlasreader/actions/runs/6030134696 |
Remi-Gau
commented
Aug 30, 2023
Remi-Gau
changed the title
|
Will let this rest for today. Finishing fixing this may require diving into libraries I am not familiar with. |
This was referenced Oct 14, 2023
Closed
|
I was able to make the tests pass, and updated the faulty badges. But now it crashes do to some coveralls issue. Unfortunately I'm not familiar with coveralls or its github-actions. I registered on coveralls.io and added the a token via the command line, but it's still failing. Any idea how to debug this? |
the action was fine I just had forgotten to generate the coverage report. 🙈 BTW: added python 3.12 in CI |
|
Oh super! Thank you for all of this! Looks good to me, will go ahead and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.