Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes when rendering tables with headings #12

Closed
miyuchina opened this issue Jan 11, 2018 · 1 comment
Closed

Crashes when rendering tables with headings #12

miyuchina opened this issue Jan 11, 2018 · 1 comment
Assignees
@miyuchina
Labels
bug

Comments

@miyuchina
Copy link
Owner

Broken in mistletoe 0.4.1. Spotted by @cctile in #10. Derp.

The cause is that since 0.4.1 token.children returns a list (or tuple), and HTMLRenderer and LaTeXRenderer tries to call next on the list (or tuple).

I could patch it the easy way, but the neater solution will change the Table class slightly, and make future render_table functions less gross.
@miyuchina miyuchina self-assigned this Jan 11, 2018
@miyuchina miyuchina added the bug label Jan 11, 2018
miyuchina pushed a commit that referenced this issue Jan 11, 2018
🐛 fixed: render_table crashing when iterating token.children (#12)
5436e70
@miyuchina
Copy link
Owner Author

Well that was fast. Fixed in 5436e70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miyuchina miyuchina

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miyuchina