New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y_fix: text-link #7

Merged

mizchi merged 3 commits into mizchi:master from yamanoku:fix/text-link-color

May 19, 2020

Contributor

yamanoku commented May 19, 2020

テキストリンクのコントラスト比が弱かったのでコントラスト比高いのに変更
- https://tailwindcss.com/docs/text-color/
700になったのでhover時の800と色の差が大きくなくなるのでunderlineでリンクホバーの可否を変更
- https://tailwindcss.com/docs/text-decoration/
Lighthouseのアクセシビリティ判定で100点取れるように
- 詳細ページのamp-social-shareはこちらでいかんともしがたいのでスルー

yamanoku added 3 commits

May 19, 2020 22:14


          fix:link-color-contrast

e9c1252


          feat:underline

7110ee6


          fix:color-contrast

94b3474

mizchi merged commit e73c397 into mizchi:master

yamanoku deleted the fix/text-link-color branch

May 31, 2020 23:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment