Use Lazy class instead of raw function
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizdra
changed the title
Lazy class instead of raw functionLazy class instead of raw function
mizdra
commented
Aug 19, 2023
| } else { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| return fieldResolver as any; |
There was a problem hiding this comment.
Previously, a cast to any type was required, but this fix removes it :).
|
Frankly, I was not sure if I should support this edge case. However, the ability to eliminate the cast to any type was very appealing. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1
follow-up: #3
Users can deserialize GraphQL custom scalar types to their favorite application types. Thus, the type of an application-level field can be any type.
For example, a custom scalar type can be deserialized into a function. However, graphql-fabbrica did not support it. graphql-fabbrica incorrectly interpreted a field deserialized into a function as a lazily evaluated field.
This PR introduces a lazy class so that graphql-fabbrica can distinguish between lazily evaluated fields and fields deserialized into functions.
References