Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich reported Progress in multipart upload request #23

Closed
nemphys opened this issue Jul 2, 2020 · 3 comments · Fixed by #24
Closed

Enrich reported Progress in multipart upload request #23

nemphys opened this issue Jul 2, 2020 · 3 comments · Fixed by #24

Comments

@nemphys
Copy link

nemphys commented Jul 2, 2020

Currently, I can see that it is possible to attach a ProgressTracker to a MultPartBodyPublisher in order to track the progress of an upload, but the returned Progress object only contains the time/bytes information for the whole request.

This is fine for single-file upload requests, but if the request involves uploading multiple files, it would be nice to provide the current file information, along with a per file progress value.

@mizosoft
Copy link
Owner

mizosoft commented Jul 4, 2020

Yes I believe this would be a nice enhancement to ProgressTracker. I'm guessing it won't be straightforward as hooks must be added to MultipartBodyPublisher itself to get notified of part changes. Will see what I can do.

Thanks for the suggestion!

mizosoft added a commit that referenced this issue Jul 16, 2020
mizosoft added a commit that referenced this issue Jul 16, 2020
mizosoft added a commit that referenced this issue Jul 16, 2020
@nemphys
Copy link
Author

nemphys commented Jul 19, 2020

Thanks for this, a new release would be greatly appreciated.

@mizosoft
Copy link
Owner

mizosoft commented Jul 20, 2020

I wanted to consider a RateLimiter for 1.4 but not yet sure, will see in about 3~4 days. In the meantime you can use 1.4.0-SNAPSHOT for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants