Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShareJS now works again with meteor 1.3 and ace 1.2 #67

Closed
wants to merge 6 commits into from

Conversation

DavidSichau
Copy link
Collaborator

Now ShareJS Ace works again with meteor 1.3.

Problems

  • Loading fo ace editor takes longer
  • Build time very huge, because of the inclusion of the whole ace editor. To reduce the build time all except the src folder of ace-build folder should be deleted.

Advantages

  • Works with newest Ace Versions
  • Base Package does not need any editor specific code
  • Works again with meteor 1.3

fixes #65
fixes #55

@DavidSichau
Copy link
Collaborator Author

@mizzao Any Chance that this gets merged? At the moment this is blocking us to update the our application to meteor 1.3. And I want to avoid to publish the package independently.

@vincentracine
Copy link

Awaiting the merge so I can upgrade to Meteor 1.3

@mizzao
Copy link
Owner

mizzao commented Apr 8, 2016

Sorry guys, I'm traveling and will have to review this later.

@jakubfiala
Copy link

Hi @mizzao would it be possible to merge this at all? Of course I understand if you don't have time to check it, but many people would really benefit from being able to upgrade to 1.3 and still use this package.

@DavidSichau
Copy link
Collaborator Author

DavidSichau commented Apr 24, 2016

Deleted as mizzao:sharejs packages where updated.

@mizzao
Copy link
Owner

mizzao commented Apr 25, 2016

@DavidSichau, would you like to be added to the publishers list for this package and just push it out directly under mizzao:sharejs, or do you want to maintain your own fork?

@DavidSichau
Copy link
Collaborator Author

DavidSichau commented Apr 25, 2016

@mizzao I think publishing under your name makes sense when the changes are added to this repo. Otherwise another name would be better to avoid a difference in the source code and the published packages.

@mizzao
Copy link
Owner

mizzao commented Apr 25, 2016

@DavidSichau - I'm asking if you want push access to this repo and publishing rights to the Meteor package name :)

It's better to have someone actively using this maintaining it than someone who isn't!

@DavidSichau
Copy link
Collaborator Author

@mizzao That would be great. I will try to maintain this package then in the future.

@mizzao
Copy link
Owner

mizzao commented Apr 25, 2016

Great. What's your Meteor username? I will add you to this repo and add your Meteor account to the atmosphere package as well.

I'm happy to answer any questions about maintaining the package or other confusing things, if you run into issues.

@DavidSichau
Copy link
Collaborator Author

DavidSichau commented Apr 25, 2016

The meteor username is: davidsichau

I will start to merge my changes tomorrow and publish the compatible version of the package.

@mizzao
Copy link
Owner

mizzao commented Apr 25, 2016

Great, davidsichau can now publish for mizzao:sharejs, mizzao:sharejs-ace, and mizzao:sharejs-codemirror.

@DavidSichau DavidSichau mentioned this pull request Apr 26, 2016
@DavidSichau
Copy link
Collaborator Author

@jakubfiala Please use again the mizzao share js packages. I have updated them to the newest version.

@jakubfiala
Copy link

that's brilliant, thank you very much @DavidSichau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not working in Meteor 1.3 Ace editor 1.2.0 is compatible with ShareJS 0.6
4 participants