Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented check_belongs_to_system_account #694

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Implemented check_belongs_to_system_account #694

merged 2 commits into from
Aug 1, 2019

Conversation

takumin
Copy link
Contributor

@takumin takumin commented Jul 31, 2019

Motivation

After adding with system_[user|group], I want to check whether it is a system account correctly.

SYS_UID_MIN, SYS_UID_MAX

The default value for SYS_UID_MIN (resp.  SYS_UID_MAX) is 101 (resp.  UID_MIN-1).

SYS_GID_MIN, SYS_GID_MAX

The default value for SYS_GID_MIN (resp.  SYS_GID_MAX) is 101 (resp.  GID_MIN-1).

Appendix

See also: login.defs(5)

@takumin takumin mentioned this pull request Jul 31, 2019
Open
@mizzy
Copy link
Owner

mizzy commented Aug 1, 2019

check_is_system_user and check_is_system_group sounds more naturally for me.

@takumin
Copy link
Contributor Author

takumin commented Aug 1, 2019

Thank you for your reply.
I can agree with the content of your suggestion.

Changed to check_is_system_user and check_is_system_group.
Please reply again if you have other necessary work.

@mizzy
Copy link
Owner

mizzy commented Aug 1, 2019

LGTM!

@mizzy mizzy merged commit 5eea5c7 into mizzy:master Aug 1, 2019
@mizzy
Copy link
Owner

mizzy commented Aug 1, 2019

Released as v2.81.0.

@takumin takumin deleted the check_belongs_to_system_account branch August 1, 2019 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@takumin @mizzy