Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should load a joke from URL param #12

Closed
mj-meyer opened this issue Dec 4, 2019 · 1 comment
Closed

Should load a joke from URL param #12

mj-meyer opened this issue Dec 4, 2019 · 1 comment
Assignees
@mj-meyer
Labels
enhancement New feature or request
Projects
HowToDad
Milestone
Launch HowToDad App

Comments

@mj-meyer
Copy link
Owner

mj-meyer commented Dec 4, 2019

Should load a joke from "myjson" or "icanhazdadjoke". Not sure which would be the best option. As long as this works.
@mj-meyer mj-meyer added the enhancement New feature or request label Dec 4, 2019
@mj-meyer mj-meyer added this to the Launch HowToDad App milestone Dec 4, 2019
@mj-meyer mj-meyer self-assigned this Dec 4, 2019
@mj-meyer mj-meyer added this to To do in HowToDad via automation Dec 4, 2019
@mj-meyer mj-meyer mentioned this issue Dec 4, 2019
Closed
mj-meyer added a commit that referenced this issue Dec 8, 2019
@mj-meyer
share jokes feature (#22)
2590352 
closes #8 #12 #13 

* add share library
- get jokes method
- save jokes method

* share joke on individual joke

* share all jokes implemented
copy share link

* load from URL params
copy to clipboard
@mj-meyer
Copy link
Owner Author

mj-meyer commented Dec 8, 2019

closed by #22

@mj-meyer mj-meyer closed this as completed Dec 8, 2019
HowToDad automation moved this from To do to Done Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mj-meyer mj-meyer

Labels
enhancement New feature or request
Projects
HowToDad
  
Done
Milestone
Launch HowToDad App
Development

No branches or pull requests
1 participant
@mj-meyer