Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak plot_1d_comparison #102

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Tweak plot_1d_comparison #102

merged 3 commits into from
Jul 26, 2021

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Jul 26, 2021

Tweak nessai.plot.plot_1d_comparison to prevent an error when plotting live points with a field that does not contain any finite values.

Also, adds a colours argument to the function as a consequence of this change and raise errors if labels or colours are the wrong length.

@mj-will mj-will added bug Something isn't working enhancement New feature or request labels Jul 26, 2021
@mj-will mj-will added this to the v0.3.1 milestone Jul 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #102 (d097681) into main (67dd26d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   94.31%   94.33%   +0.02%     
==========================================
  Files          39       39              
  Lines        3515     3533      +18     
==========================================
+ Hits         3315     3333      +18     
  Misses        200      200              
Flag Coverage Δ
unittests 94.33% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nessai/plot.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dd26d...d097681. Read the comment docs.

@mj-will
Copy link
Owner Author

mj-will commented Jul 26, 2021

Example of skipping a parameter with infinite values. All values for 1 are plotted, 'y' is skipped for 0 (blue).

image

@mj-will mj-will merged commit 906c098 into main Jul 26, 2021
@mj-will mj-will deleted the tweak-plot-1d-comp branch July 26, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants