Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve realnvp exceptions and tests #109

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Sep 3, 2021

Make the exceptions raised for incorrect input values more verbose and add tests for parts of the code that were not being tested.

@mj-will mj-will added enhancement New feature or request tests Improvements or additions to the test suite labels Sep 3, 2021
@mj-will mj-will added this to the v0.3.2 milestone Sep 3, 2021
@mj-will mj-will self-assigned this Sep 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #109 (be0009e) into main (230ef47) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   94.41%   94.64%   +0.22%     
==========================================
  Files          39       39              
  Lines        3547     3549       +2     
==========================================
+ Hits         3349     3359      +10     
+ Misses        198      190       -8     
Flag Coverage Δ
unittests 94.64% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nessai/flows/realnvp.py 100.00% <100.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230ef47...be0009e. Read the comment docs.

@mj-will mj-will merged commit 06a5d4a into main Sep 3, 2021
@mj-will mj-will deleted the improve-realnvp-exceptions-and-tests branch September 3, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Improvements or additions to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants