Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check valid noise scale #115

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Check valid noise scale #115

merged 3 commits into from
Oct 11, 2021

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Oct 11, 2021

Adds a check in nessai.flowmodel.update_config for the value of noise_scale which should be either a float or 'adaptive'.

Currently, FlowModel can be initialised with invalid values and an unhelpful error is only raised when trying to train the flow.

@mj-will mj-will added the enhancement New feature or request label Oct 11, 2021
@mj-will mj-will added this to the v0.3.2 milestone Oct 11, 2021
@mj-will mj-will self-assigned this Oct 11, 2021
@mj-will mj-will merged commit 3eaa9a3 into main Oct 11, 2021
@mj-will mj-will deleted the check-valid-noise-scale branch October 11, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mj-will mj-will

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mj-will