Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constant volume mode #125

Merged
merged 8 commits into from Nov 5, 2021
Merged

Add constant volume mode #125

merged 8 commits into from Nov 5, 2021

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Nov 5, 2021

Add a constant volume mode to FlowProposal. In this mode the radius of the latent contour is fixed to the q'th quantile of an n-dimensional Gaussian, which by default is 0.95.

@mj-will mj-will added the enhancement New feature or request label Nov 5, 2021
@mj-will mj-will added this to the v0.4.0 milestone Nov 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #125 (420d254) into main (b21ac5d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   94.78%   94.81%   +0.02%     
==========================================
  Files          39       39              
  Lines        3569     3588      +19     
==========================================
+ Hits         3383     3402      +19     
  Misses        186      186              
Flag Coverage Δ
unittests 94.81% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nessai/utils/__init__.py 100.00% <ø> (ø)
nessai/proposal/flowproposal.py 96.91% <100.00%> (+0.07%) ⬆️
nessai/utils/sampling.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21ac5d...420d254. Read the comment docs.

@mj-will mj-will merged commit c744a4c into main Nov 5, 2021
@mj-will mj-will deleted the use-fixed-latent-volume branch November 5, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants