Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Proposal #92

Merged
merged 7 commits into from
Jul 13, 2021
Merged

Add tests for Proposal #92

merged 7 commits into from
Jul 13, 2021

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Jul 11, 2021

Add complete tests for nessai.proposal.base.Proposal.

Also changes Proposal to inherit from abc.ABC so that draw is an abstract method.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #92 (c2b5b65) into main (e7f3b97) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   91.68%   92.03%   +0.34%     
==========================================
  Files          29       29              
  Lines        3487     3489       +2     
==========================================
+ Hits         3197     3211      +14     
+ Misses        290      278      -12     
Flag Coverage Δ
unittests 92.03% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nessai/proposal/base.py 97.43% <100.00%> (+29.01%) ⬆️
nessai/proposal/analytic.py 90.32% <0.00%> (-9.68%) ⬇️
nessai/proposal/rejection.py 97.91% <0.00%> (-2.09%) ⬇️
nessai/proposal/flowproposal.py 96.84% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f3b97...c2b5b65. Read the comment docs.

@mj-will mj-will added this to the v0.3.1 milestone Jul 13, 2021
@mj-will mj-will mentioned this pull request Jul 13, 2021
@mj-will mj-will merged commit dfd50ea into main Jul 13, 2021
@mj-will mj-will deleted the test-base-proposal branch July 14, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants