Revert "[TextField] fix running click event on disabled (mui#36892)"

This reverts commit 9118505.
mj12albert · Aug 14, 2023 · df79a98 · df79a98
1 parent 9bec39b
commit df79a98
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 29 deletions.
diff --git a/packages/mui-material/src/InputBase/InputBase.js b/packages/mui-material/src/InputBase/InputBase.js
@@ -440,7 +440,8 @@ const InputBase = React.forwardRef(function InputBase(inProps, ref) {
     if (inputRef.current && event.currentTarget === event.target) {
       inputRef.current.focus();
     }
-    if (onClick && !fcs.disabled) {
+
+    if (onClick) {
       onClick(event);
     }
   };

diff --git a/packages/mui-material/src/TextField/TextField.d.ts b/packages/mui-material/src/TextField/TextField.d.ts
@@ -111,10 +111,6 @@ export interface BaseTextFieldProps
   name?: string;
   onBlur?: InputBaseProps['onBlur'];
   onFocus?: StandardInputProps['onFocus'];
-  /**
-   * @ignore
-   */
-  onClick?: InputBaseProps['onClick'];
   /**
    * The short hint displayed in the `input` before the user enters a value.
    */

diff --git a/packages/mui-material/src/TextField/TextField.js b/packages/mui-material/src/TextField/TextField.js
@@ -95,7 +95,6 @@ const TextField = React.forwardRef(function TextField(inProps, ref) {
     name,
     onBlur,
     onChange,
-    onClick,
     onFocus,
     placeholder,
     required = false,
@@ -179,7 +178,6 @@ const TextField = React.forwardRef(function TextField(inProps, ref) {
       onBlur={onBlur}
       onChange={onChange}
       onFocus={onFocus}
-      onClick={handleClick}
       placeholder={placeholder}
       inputProps={inputProps}
       {...InputMore}
@@ -358,10 +356,6 @@ TextField.propTypes /* remove-proptypes */ = {
    * You can pull out the new value by accessing `event.target.value` (string).
    */
   onChange: PropTypes.func,
-  /**
-   * @ignore
-   */
-  onClick: PropTypes.func,
   /**
    * @ignore
    */

diff --git a/packages/mui-material/src/TextField/TextField.test.js b/packages/mui-material/src/TextField/TextField.test.js
@@ -1,7 +1,6 @@
 import * as React from 'react';
 import { expect } from 'chai';
-import { spy } from 'sinon';
-import { createRenderer, describeConformance, fireEvent } from 'test/utils';
+import { createRenderer, describeConformance } from 'test/utils';
 import FormControl from '@mui/material/FormControl';
 import { inputBaseClasses } from '@mui/material/InputBase';
 import MenuItem from '@mui/material/MenuItem';
@@ -155,22 +154,6 @@ describe('<TextField />', () => {
     });
   });
 
-  describe('prop: disabled', () => {
-    it('should not run click event when disabled', () => {
-      const handleClick = spy();
-      const { getByRole } = render(<TextField disabled onClick={handleClick} />);
-      fireEvent.click(getByRole('textbox'));
-      expect(handleClick.callCount).to.equal(0);
-    });
-
-    it('should not run click event when disabled and when onClick prop is set through InputProps', () => {
-      const handleClick = spy();
-      const { getByRole } = render(<TextField disabled InputProps={{ onClick: handleClick }} />);
-      fireEvent.click(getByRole('textbox'));
-      expect(handleClick.callCount).to.equal(0);
-    });
-  });
-
   describe('prop: select', () => {
     it('can render a <select /> when `native`', () => {
       const currencies = [