-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a submission progress bar #150
Comments
Hmm, what's your use case for this? The amount of data shouldn't be anything too crazy even for a quite large amount of reports and its sent in a compressed format. We don't know beforehand how many bytes the reports will be, because JSON serialization and compression are done in streaming mode when sending the data I'll think about how to improve the submit data button. Right now it doesn't tell whether the data submission was successful and it can get "stuck" in disabled mode if the submission fails and it's waiting for WorkManager to retry |
I have had occasions when uploading data took more than a minute, even on a pretty fast upload connection, but if this is too much work, then do not worry about it. |
This depends a lot on the server also. Ichnaea seems to be quite slow, but my own custom implementation and beacondb.net work fast even for a large amount of data |
I'm submitting to BeaconDB. If this looks like it's not worth implementing, feel free to close the issue, I'll let you know if I have any more severe problems with submissions. |
I would like this too, +1 from me. |
Given the apparent technical complexity of a progress bar, and 1.3.1 adding a little toast confirming the submission is successful, I feel like the submission process has gotten a lot less ambiguous, and has resolved the core concern of my original issue, will be closing this issue unless @mjaakko wants it to stay open. |
When using NeoStumbler in a dense city, a lot of data is collected very quickly. When hitting "submit reports", I have no idea how much data will be used, or if the upload has been interrupted, or is just going slow. Would you consider adding a readout of many megabytes will be uploaded when pressing "submit reports"? Would you maybe consider providing a progress bar for the data upload?
The text was updated successfully, but these errors were encountered: