Bundle with Rollup instead of Webpack #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mjackson!
I'm opening this PR in regards to your suggestion of using Rollup instead of Webpack to get tree-shaking working: remix-run/react-router#6608 (comment)
Unfortunately, even if we switch from Webpack to Rollup with a proper dead-code elimination config, tree-shaking still doesn't work. Note that
createHashHistorystill unnecessarily appears in the output. 馃槩(This happens for a similar reason as with Webpack. Rollup is only able to look at a single, bundled react-router-dom.js which contains all of the
historyimports. Its static module analysis isn't smart enough to determine that e.g.HashRouter, and thereforecreateHashHistory, are unused.HashRouterdoes get eliminated later in DCE by the minifier, but, by then, the entirehistorymodule has been included in the bundle. You can confirm this by commenting out the minifier plugin in the Rollup config.)