Add ability to pass in an array of vals instead of as separate params

[toddbluhm]

• Fixed so del now accepts an array of keys rather than just lots of
  params (should work for other commands too)
• Added test cases for the del command, testing both multiple params
  and one array param
• Updated .gitignore to include node_modules

[mjackson]

The way I've been handling this before now is by defining small wrapper methods around commands that accept multiple keys. e.g. see the implementation of MGET. That way we only do the extra work on commands that may need it instead of all of them.

[toddbluhm]

Yeah I tried to take a more general approach to the problem to solve this issue for other commands that might take arrays. I will do the wrapper style :)

[mjackson]

Ya, let's stick with the existing style. Thanks!

Michael Jackson
@mjackson

On Fri, Dec 19, 2014 at 3:58 PM, Todd Bluhm notifications@github.com
wrote:

In modules/Client.js
#26 (diff):

@@ -212,7 +212,11 @@ require('redis/lib/commands').forEach(function (command) {

Object.defineProperty(Client.prototype, command, {
value: function () {

•  return this.send(command, slice.call(arguments, 0));
  

•  var args = slice.call(arguments, 0);
  

•  if(args.length && Array.isArray(args[0])) {
  

•    return this.send(command, args.shift().concat(args));
  

Yeah I tried to take a more general approach to the problem to solve this
issue for other commands that might take arrays. I certainly can do a
wrapper style like that if you would prefer?

—
Reply to this email directly or view it on GitHub
https://github.com/mjackson/then-redis/pull/26/files#r22136618.

[mjackson]

@toddbluhm Perfect. Thank you!

[mjackson]

@toddbluhm Just a heads up, this work is included in version 1.2.0, just released. Cheers!