Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that the database index is a number before selecting #40

Merged
merged 1 commit into from Mar 18, 2015
Merged

check that the database index is a number before selecting #40

merged 1 commit into from Mar 18, 2015

Conversation

jonathanong
Copy link
Contributor

closes #38

mjackson added a commit that referenced this pull request Mar 18, 2015
check that the database index is a number before selecting
@mjackson mjackson merged commit 341fbb9 into mjackson:master Mar 18, 2015
@mjackson
Copy link
Owner

Makes sense. Thanks!

@jonathanong jonathanong deleted the select-database-index branch March 18, 2015 15:51
@digitalcora
Copy link

@mjackson Will there be a point release that incorporates this fix? Just spent a good few hours banging my head against an "invalid DB index" error, because Heroku Redis provides URLs that look like:

redis://h:secretpassword@ec2-127-0-0-1.compute-1.amazonaws.com:6629

Note the "h", which I assume is included to avoid tripping up URL parsers that always expect a password to be accompanied by a username.

@amiel
Copy link

amiel commented Oct 29, 2015

+1 for a point release; I need this too

Also, It seems like the standard for specifying the database is the first path segment instead of the http basic auth username (so redis://host/0 instead of redis://0:@host. What are your thoughts of using that instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants