Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to sort extensions by enabled status #130

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Add option to sort extensions by enabled status #130

merged 6 commits into from
Mar 21, 2022

Conversation

mjakeman
Copy link
Owner

@mjakeman mjakeman commented Mar 19, 2022 •
edited

  • Add setting to sort extensions by enabled status
  • Display enabled extensions first
  • Fix crash that sometimes occurs
  • Respect setting state
  • Fix sometimes broken behaviour
    • Accessing ExmExtensionRow with the GTK inspector causes the application to crash
    • Fix desync between the list model and the rows as a result of sorting
    • Toggling extensions makes rows slowly become wider??

Fixes #97

@mjakeman mjakeman marked this pull request as ready for review March 21, 2022 10:56
@mjakeman mjakeman enabled auto-merge March 21, 2022 10:56
@mjakeman mjakeman merged commit fd29e01 into master Mar 21, 2022
@mjakeman mjakeman deleted the sort-by-enabled branch March 21, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to sort installed extensions by state (turned on or off)
1 participant
@mjakeman