fix: move icons to gressource #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjakeman
requested changes
Aug 31, 2022
There was a problem hiding this comment.
Thanks for working on this!
The change looks good to me - makes sense to bundle them as resources.
It seems like you've changed the formatting for exm-rating.c. I'm not sure if there is any change here, or if it's just been formatted by accident, but please stick to the project's coding style.
|
Oh sorry, it's because I thought that I need to change something but i was wrong |
|
Fixed |
mjakeman
requested changes
Sep 1, 2022
mjakeman
approved these changes
Sep 19, 2022
|
Let's get this merged for 0.4, thanks for the contribution! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icons are currently installed in datadir, it can cause conflict with others apps (maybe they are using the same icons). So, i move icons to
gressource