Add snap support. #314
Add snap support. #314
Conversation
add libadwaita for runtime dependency and add desktop entry
move override-pull to parts
remove development build flag
cleanup snap content
add dbus slot
stable release
Update location of icon file
|
Hi, thanks for working on this! At a high level it all looks good to me. I'll have to test this in some detail but I'm happy to keep the snap build files in-tree as an 'official' port. One comment: could you please rename the app from |
Rename to extension-manager.
Revert cleanup because libgtk4 in gnome-42-2204 is too old.
Add network plug and change install prefix to /usr.
|
This configuration is now usable. |
Switch to devmode to disable apparmor. Can't find a plug to support extension managing. (Dbus message is blocked by apparmor)
|
Hi @dingdang66686, sorry for the delay in testing. It seems snapcraft is completely broken on the arm64 architecture, at least on the two distributions I've tried it on, so I'm unable to test the snap at the moment. I'll try dig up an x86 laptop to test it with soon. In regards to snap support, I notice you've got a package here: https://snapcraft.io/gnome-extension-manager. Did you want to continue maintaining this unofficially, or transfer ownership and have it maintained upstream (as part of this PR)? |
|
Well, I create this package just for testing. If there is no problem, I'm glad to make this maintained upstream. |
|
I have to mention that this application doesn't work in sandboxed mode. When apparmor is enabled, the dbus message is blocked. I have checked the official documentation but without luck. |
It takes several minutes on first build, because it will create a vm (if the snap uses core22 as a base, a lxd container by default) and pull all the dependencies. If it is extremely slow, you should check your internet connection to ubuntu repositories and the snap repository. |
|
https://1drv.ms/u/s!AjQ7y8jf_bBFmIRY_zOSIdzXAMD-6w?e=CfKWrG @mjakeman Test this snap on your arm64 device. |
|
Hi @dingdang66686, I've finally had the chance to review and test this. I've fixed the issues I was having with arm snaps by using an Ubuntu VM image. On the whole, the package looks good. There are a few points:
|
|
Unfortunately, AppArmor prevents the app from using dbus, meaning that it can't install anything now.
There isn't anything stopping the app from working with confinement (by design), so I'd ask that the snap file declares the proper permissions so we can use strict confinement. Maybe this will help: https://forum.snapcraft.io/t/the-dbus-interface/2038 |
|
As the document says, the dbus interface is only for communications between snaps. I don't think this will help. |
Yep, you're absolutely right. I misread that, apologies. I've spent a lot of time looking at snap interfaces and how we can work around this for confinement purposes. Unfortunately, if there is a solution it does not look trivial (which is a bit odd, given that DBus is the primary means of achieving confinement under flatpak). Thanks for your patience with this PR - I'm happy to take this as-is in time for the 0.4.1 release, and we can look at tightening things up later on. Much appreciated! |
|
Hi @dingdang66686, I'm looking at making a new release of Extension Manager in the next week or so. I'm happy to take ownership of the snap package and handle releases if you're agreeable? |
|
I'm glad to do so. 😁 |
|
Maybe we should ask snap developers to add a new slot/plug for gnome extension managing. |
|
Great! I've opened a request: https://forum.snapcraft.io/t/transfer-ownership-of-extension-manager-and-rename-package/33870?u=mjakeman
I think that's a good idea. Let's publish v0.4.1 using classic confinement so we have a working version out in the wild. We can ask for either a session-dbus interface, or maybe some kind of gnome-specific plug that whitelists |
|
You can register a different snap named extension-manager. Then I will close my snap. |
No description provided.