exm-backtrace.c: Explicitly include stdint.h for uintptr_t usage #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file uses type uintptr_t from stdint.h, which is indirectly included by backtrace.h. Even so, the file should unconditionally include stdint.h just in case backtrace.h no longer includes stdint.h in the future. Signed-off-by: Yuan Liao <liaoyuan@gmail.com>
|
Yep, this makes sense. Nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file uses type
uintptr_tfromstdint.h, which is indirectly included bybacktrace.h. Even so, the file should unconditionally includestdint.hjust in casebacktrace.hno longer includesstdint.hin the future.