Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to new Libadwaita widgets #459

Merged
merged 9 commits into from
Oct 1, 2023
Merged

Port to new Libadwaita widgets #459

merged 9 commits into from
Oct 1, 2023

Conversation

oscfdezdz
Copy link
Collaborator

@oscfdezdz oscfdezdz commented Aug 13, 2023

Includes #457 and #458 for now.

image

image

Fix #132

@oscfdezdz
Copy link
Collaborator Author

I tried to improved the diff but indentation doesn't help 😅 Other than that, this is ready for review even though it's marked as a draft, but that's because runtime version 45 isn't released yet.

@oscfdezdz
Copy link
Collaborator Author

Added b4041e9 which fixes #132

@oscfdezdz
Copy link
Collaborator Author

oscfdezdz commented Aug 19, 2023

Using the 45beta runtime already available in flathub-beta.

https://discourse.gnome.org/t/gnome-45-beta-released/16766/2

@oscfdezdz oscfdezdz marked this pull request as ready for review August 31, 2023 07:27
Copy link
Owner

@mjakeman mjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup. The new Adw.NavigationView makes this a lot less fragile.

Let's merge it - if there are any minor problems we can fix them later

@mjakeman mjakeman merged commit 6462511 into mjakeman:master Oct 1, 2023
1 check passed
@oscfdezdz oscfdezdz deleted the adw-1-4 branch October 1, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make release notes translatable
2 participants