Improve keyboard navigation #463
Conversation
I tried to track down these issues of GNOME Circle application to include a fix in this PR, without much success.
I couldn't figure out why this one happens. When toggling a switch from one of the groups, user-installed or system, the first switch of the group always grabs the focus.
This button is focusable, although when pressed, focus can go behind the overlay using the keyboard which is probably undesirable. The solution here could be to intercept key press events and return the focus if the overlay is active and moves behind it, but maybe I'm just overthinking it. |
|
I've opened #485 to track the remaining issues. I think this is a good start. Regarding the extension toggle, of the top of my head this is because it recreates the entire group rather than updating the individual row state (it might not actually be the case, I wrote that code nearly two years ago 😅). We should get this for free with the unified extensions model from #67 which is prototyped in @oscfdezdz Could you rebase this please? Then happy to merge |
It enables F10 shortcut to open it. See https://developer.gnome.org/hig/patterns/controls/menus.html#primary-menus
It's ready now, I also added the action to close the comments dialog with |
It contains no label to be read by screen readers, the buttons inside are already focusable.
No description provided.